Register - Login
Views: 99804880
Main - Memberlist - Active users - Calendar - Wiki - IRC Chat - Online users
Ranks - Rules/FAQ - Stats - Latest Posts - Color Chart - Smilies
05-03-22 07:43:30 AM
Jul - Meta - Please fix the formatting bar! New poll - New thread - New reply
Next newer thread | Next older thread
Deleted User
Collection of nobodies
Posted on 03-14-09 06:32:35 PM (last edited by Pixel1024 at 03-14-09 07:22 PM) Link | Quote
I was looking at the threads in the General forum. This one catched my attention, because I like programming and bugfixing. I've read it and learnt there's a formatting bar in the reply page, that only works under IE. So I've tried with IE, and indeed there's a formatting bar, and indeed it doesn't show up under Firefox and other navigators.

See below. I've fixed it; hoping the fix will be included soon.

____________________


===================
[Posted by Pixel1024]
Tiden
Disgusting human being, just awful
Level: NaN


Posts: 3533/-6493
EXP: NaN
For next: 0

Since: 07-03-07

Pronouns: they/them

Since last post: 4.1 years
Last activity: 3.6 years

Posted on 03-14-09 07:00:33 PM Link | Quote
This is not likely going to be fixed any time soon*



*: never







I might fix it myself if I get the time/motivation to do so.
Liliana
"A horrible person". That's what it says. "A horrible person."

We weren't even testing for that.


Level: NaN


Posts: 225/-3841
EXP: NaN
For next: 0

Since: 07-23-07


Since last post: 10.3 years
Last activity: 10.1 years

Posted on 03-14-09 07:11:08 PM Link | Quote
Of course, if someone were to provide the working JS code, it would get fixed somewhat faster.

____________________
Deleted User
Collection of nobodies
Posted on 03-14-09 07:16:47 PM (last edited by Pixel1024 at 03-14-09 04:20 PM) Link | Quote
Here is the formatting bar code, if I'm correct:




<script src=js/menu.js></script>
<script src=js/button.js></script>
<script src=js/toolbar.js></script>
<script>
Array.prototype.id="Menu1";
Array.prototype.imgname="m1";
m1Menu=new Array(7)
m1Menu[0]=new menuLink('<img src=images/toolbar/fred.gif alt=Red','window.document.REPLIER.message.value+="[red]"')
m1Menu[1]=new menuLink('<img src=images/toolbar/fyellow.gif alt=Yellow','window.document.REPLIER.message.value+="[yellow]"')
m1Menu[2]=new menuLink('<img src=images/toolbar/forange.gif alt=Orange','window.document.REPLIER.message.value+="[orange]"')
m1Menu[3]=new menuLink('<img src=images/toolbar/fgreen.gif alt=Green','window.document.REPLIER.message.value+="[green]"')
m1Menu[4]=new menuLink('<img src=images/toolbar/fblue.gif alt=Blue','window.document.REPLIER.message.value+="[blue]"')
m1Menu[5]=new menuLink('<img src=images/toolbar/fpink.gif alt=Pink','window.document.REPLIER.message.value+="[pink]"')
m1Menu[6]=new menuLink('<img src=images/toolbar/fblack.gif alt="Normal Color"','window.document.REPLIER.message.value+="[/color]"')
m3Menu=new Array(44)
m3Menu.id="Menu3";
m3Menu.imgname="m3"
m3Menu[0]=new menuLink('<img src=images/smilies/smile.gif alt=":)">',
'window.document.REPLIER.message.value+=":)"')m3Menu[1]=new menuLink('<img src=images/smilies/wink.gif alt=";)">',
'window.document.REPLIER.message.value+=";)"')m3Menu[2]=new menuLink('<img src=images/smilies/biggrin.gif alt=":D">',
'window.document.REPLIER.message.value+=":D"')m3Menu[3]=new menuLink('<img src=images/smilies/lol.gif alt=":LOL:">',
'window.document.REPLIER.message.value+=":LOL:"')m3Menu[4]=new menuLink('<img src=images/smilies/glasses.gif alt="8-)">',
'window.document.REPLIER.message.value+="8-)"')m3Menu[5]=new menuLink('<img src=images/smilies/frown.gif alt=":(">', 'window.document.REPLIER.message.value+=":("')m3Menu[6]=new menuLink('<img src=images/smilies/mad.gif alt=":mad:">',
'window.document.REPLIER.message.value+=":mad:"')m3Menu[7]=new menuLink('<img src=images/smilies/yuck.gif alt=">_<">', 'window.document.REPLIER.message.value+=">_<"')m3Menu[8]=new menuLink('<img src=images/smilies/tongue.gif alt=":P">',
'window.document.REPLIER.message.value+=":P"')m3Menu[9]=new menuLink('<img src=images/smilies/wobbly.gif alt=":S">', 'window.document.REPLIER.message.value+=":S"')m3Menu[10]=new menuLink('<img src=images/smilies/eek.gif alt="O_O">',
'window.document.REPLIER.message.value+="O_O"')m3Menu[11]=new menuLink('<img src=images/smilies/bigeyes.gif alt="o_O">',
'window.document.REPLIER.message.value+="o_O"')m3Menu[12]=new menuLink('<img src=images/smilies/bigeyes2.gif alt="O_o">',
'window.document.REPLIER.message.value+="O_o"')m3Menu[13]=new menuLink('<img src=images/smilies/cute.gif alt="^_^">',
'window.document.REPLIER.message.value+="^_^"')m3Menu[14]=new menuLink('<img src=images/smilies/cute2.gif alt="">',
'window.document.REPLIER.message.value+=""')m3Menu[15]=new menuLink('<img src=images/smilies/baby.gif alt="~:o">',
'window.document.REPLIER.message.value+="~:o"')m3Menu[16]=new menuLink('<img src=images/smilies/sick.gif alt="x_x">',
'window.document.REPLIER.message.value+="x_x"')m3Menu[17]=new menuLink('<img src=images/smilies/eyeshift.gif alt=":eyeshift:">',
'window.document.REPLIER.message.value+=":eyeshift:"')m3Menu[18]=new menuLink('<img src=images/smilies/vamp.gif alt=":vamp:">',
'window.document.REPLIER.message.value+=":vamp:"')m3Menu[19]=new menuLink('<img src=images/smilies/blank.gif alt="o_o">',
'window.document.REPLIER.message.value+="o_o"')m3Menu[20]=new menuLink('<img src=images/smilies/cry.gif alt=";_">',
'window.document.REPLIER.message.value+=";_"')m3Menu[21]=new menuLink('<img src=images/smilies/dizzy.gif alt="@_@">',
'window.document.REPLIER.message.value+="@_@"')m3Menu[22]=new menuLink('<img src=images/smilies/annoyed.gif alt="-_-">',
'window.document.REPLIER.message.value+="-_-"')m3Menu[23]=new menuLink('<img src=images/smilies/shiftright.gif alt=">_>">',
'window.document.REPLIER.message.value+=">_>"')m3Menu[24]=new menuLink('<img src=images/smilies/shiftleft.gif alt="<_<">',
'window.document.REPLIER.message.value+="<_<"')m3Menu[25]=new menuLink('<img src=images/smilies/rofl.gif alt=":rofl:">',
'window.document.REPLIER.message.value+=":rofl:"')m3Menu[26]=new menuLink('<img src=images/smilies/terror.gif alt=":terror:">',
'window.document.REPLIER.message.value+=":terror:"')m3Menu[27]=new menuLink('<img src=images/smilies/approved.gif alt=":approve:">',
'window.document.REPLIER.message.value+=":approve:"')m3Menu[28]=new menuLink('<img src=images/smilies/denied.gif alt=":deny:">',
'window.document.REPLIER.message.value+=":deny:"')m3Menu[29]=new menuLink('<img src=images/smilies/eyeshift2.gif alt=":eyeshift2:">',
'window.document.REPLIER.message.value+=":eyeshift2:"')m3Menu[30]=new menuLink('<img src=images/smilies/meow.gif alt=":meow:">',
'window.document.REPLIER.message.value+=":meow:"')m3Menu[31]=new menuLink('<img src=images/smilies/words.gif alt=":words:">',
'window.document.REPLIER.message.value+=":words:"')m3Menu[32]=new menuLink('<img src=images/smilies/smile2.png alt="(-:">',
'window.document.REPLIER.message.value+="(-:"')m3Menu[33]=new menuLink('<img src=images/smilies/ohdear.png alt=":ohdear:">',
'window.document.REPLIER.message.value+=":ohdear:"')m3Menu[34]=new menuLink('<img src=images/smilies/rlaugh.gif alt=":raddlaugh:">',
'window.document.REPLIER.message.value+=":raddlaugh:"')m3Menu[35]=new menuLink('<img src=images/smilies/raddmad.gif alt=":raddmad:">',
'window.document.REPLIER.message.value+=":raddmad:"')m3Menu[36]=new menuLink('<img src=images/smilies/raddstand.gif alt=":raddstand:">',
'window.document.REPLIER.message.value+=":raddstand:"')m3Menu[37]=new menuLink('<img src=images/smilies/raddsigh2.gif alt=":raddsigh:">',
'window.document.REPLIER.message.value+=":raddsigh:"')m3Menu[38]=new menuLink('<img src=images/smilies/raddwow.gif alt=":raddwow:">',
'window.document.REPLIER.message.value+=":raddwow:"')m3Menu[39]=new menuLink('<img src=images/smilies/jawdrop.gif alt=":jawdrop:">',
'window.document.REPLIER.message.value+=":jawdrop:"')m3Menu[40]=new menuLink('<img src=images/smilies/boatanchor.png alt=":boatanchor:">',
'window.document.REPLIER.message.value+=":boatanchor:"')m3Menu[41]=new menuLink('<img src=images/smilies/eng101.png alt=":eng101:">',
'window.document.REPLIER.message.value+=":eng101:"')m3Menu[42]=new menuLink('<img src=images/smilies/specialed.png alt=":specialed:">',
'window.document.REPLIER.message.value+=":specialed:"')m3Menu[43]=new menuLink('<img src=images/smilies/ewww.gif alt=":eww:">',
'window.document.REPLIER.message.value+=":eww:"')
function defaultButton(image,name,onClick,onMouseOver,onMouseOut) {
if(checkBrowser()) {document.write(createButton(image, name, "onClick='"+onClick+"' onMouseOver='"+onMouseOver+"' onMouseOut='"+onMouseOut+"'", "7d7bc1","a9a7d6","524fad"))}
}
</script>



What is checkBrowser()? It's meant to make the bar only show in IE, right?

____________________


===================
[Posted by Pixel1024]
Tiden
Disgusting human being, just awful
Level: NaN


Posts: 3534/-6493
EXP: NaN
For next: 0

Since: 07-03-07

Pronouns: they/them

Since last post: 4.1 years
Last activity: 3.6 years

Posted on 03-14-09 07:18:22 PM Link | Quote

  function checkBrowser()

{
return (navigator.appName == "Microsoft Internet Explorer" && parseInt(navigator.appVersion) >= 4) //checks to see if IE is running
}



Apparently so.
Deleted User
Collection of nobodies
Posted on 03-14-09 07:21:48 PM (last edited by Pixel1024 at 03-14-09 04:22 PM) Link | Quote
Why is that function needed?

I suggest we transform it to:


function checkBrowser()

{
return true;
}



____________________


===================
[Posted by Pixel1024]
Liliana
"A horrible person". That's what it says. "A horrible person."

We weren't even testing for that.


Level: NaN


Posts: 226/-3841
EXP: NaN
For next: 0

Since: 07-23-07


Since last post: 10.3 years
Last activity: 10.1 years

Posted on 03-14-09 07:24:45 PM Link | Quote
Alternatively, remove any instances of it.

You might want to save the new reply page to your computer so you can fiddle with it however you like.

____________________
Deleted User
Collection of nobodies
Posted on 03-14-09 07:31:52 PM Link | Quote
Actually, if I do it, the bar fails to load its images because their addresses are relative. But the bar doesn't seem to work correctly under Firefox anyway. I might try to code something...

____________________


===================
[Posted by Pixel1024]
Tiden
Disgusting human being, just awful
Level: NaN


Posts: 3537/-6493
EXP: NaN
For next: 0

Since: 07-03-07

Pronouns: they/them

Since last post: 4.1 years
Last activity: 3.6 years

Posted on 03-14-09 07:38:37 PM Link | Quote
Actually a better question would be "Why is the toolbar so important"
Liliana
"A horrible person". That's what it says. "A horrible person."

We weren't even testing for that.


Level: NaN


Posts: 227/-3841
EXP: NaN
For next: 0

Since: 07-23-07


Since last post: 10.3 years
Last activity: 10.1 years

Posted on 03-14-09 07:40:43 PM Link | Quote
Originally posted by hydraphatphelinez
Actually a better question would be "Why is the toolbar so important"

That's what I have been asking all the time too. The four (?) years I've lived without it, I did not miss it at all. But people seem to get annoyed by the presence of broken toolbars on a board.

____________________
Tiden
Disgusting human being, just awful
Level: NaN


Posts: 3538/-6493
EXP: NaN
For next: 0

Since: 07-03-07

Pronouns: they/them

Since last post: 4.1 years
Last activity: 3.6 years

Posted on 03-14-09 07:41:51 PM Link | Quote
Originally posted by Prince Kassad
That's what I have been asking all the time too. The four (?) years I've lived without it, I did not miss it at all. But people seem to get annoyed by the presence of broken toolbars on a board.

<sarcasm>Wimps </sarcasm>
Deleted User
Collection of nobodies
Posted on 03-14-09 07:57:50 PM (last edited by Pixel1024 at 03-14-09 04:59 PM) Link | Quote
In menu.js, try replacing the showLayer() func by this one. It should do the job.


// SHOW MENU

function showLayer(layerName, e)
{
MenuOn=1
if (NS4 || IE4 || DOM)
{
if (timeOn != null)
{
clearTimeout(timeOn)
hideLayer(onLayer)
}
if (NS4 || IE4)
{
eval(layerName+'.style.left=e.clientX-e.offsetX')
eval(layerName+'.style.top=e.clientY')
eval(layerRef+'["'+layerName+'"]'+styleSwitch+'.visibility="visible"')

activeLayer=layerName;
}
if (DOM)
{
document.getElementById(layerName).style.visibility='visible';
document.getElementById(layerName).style.left=e.clientX;
document.getElementById(layerName).style.top=e.clientY;
}
}
onLayer = layerName
}



And of course don't forget to remove the calls to checkBrowser()

____________________


===================
[Posted by Pixel1024]
Tina
Beep boop
Level: 79


Posts: 703/1549
EXP: 4471617
For next: 107850

Since: 08-10-07


Since last post: 3.4 years
Last activity: 3.4 years

Posted on 03-14-09 08:23:12 PM Link | Quote
I will consider implementing your fixes, but more likely than not it will just be completely rewritten.

It is also of a very, very low priority right now, so.

____________________
Deleted User
Collection of nobodies
Posted on 03-14-09 08:33:26 PM (last edited by Pixel1024 at 03-14-09 05:38 PM) Link | Quote
But implementing this fix isn't that much to do. It is just matter of opening menu.js, copy-pasting the new showLayer() func, saving and closing the file, et voila, it's fixed!

EDIT: oops. There are also the calls to checkBrowser(). But you can just make it return true.

____________________


===================
[Posted by Pixel1024]
Lyskar
12210
-The Chaos within trumps the Chaos without-
Level: 192


Posts: 2247/12211
EXP: 99321381
For next: 552190

Since: 07-03-07

From: 52-2-88-7

Since last post: 7.4 years
Last activity: 7.3 years

Posted on 03-14-09 10:08:27 PM Link | Quote

Time/Date

03-14-09 04:08:27pm

Posts

2247

Days Here

620

Level

68
Metal_Man88
Local Moderator
I'll just snatch it for use on my board instead :p

____________________
Original Layout © Tobias Kelmandia
Next newer thread | Next older thread
Jul - Meta - Please fix the formatting bar! New poll - New thread - New reply


Rusted Logic

Acmlmboard - commit 47be4dc [2021-08-23]
©2000-2022 Acmlm, Xkeeper, Kaito Sinclaire, et al.

28 database queries, 3 query cache hits.
Query execution time: 0.090532 seconds
Script execution time: 0.028998 seconds
Total render time: 0.119530 seconds